-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord AHelp Reply System #2315
Discord AHelp Reply System #2315
Conversation
* First part of Remote Bwoinking * This should technically work * No Actoring * Fixes Guid not sending over * Making it work for the final. * Fixes for api * Moar Commants! Just more Comments to mark Frontier changes. * comment * wops * Fixes Naming Rules * I Should also fix the naming in the actually code... * Testing some new code * Naming rule and dependency fix (hopefully) * Serverside Webhook update on external sent ahelp messages * Still get data from custom URL's, even if it dosent match a discord webhook * Apply suggestions from code review (Part 1) Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> * Apply suggestions from code review (Part 2) * Bwoink system suggsetions * missing BwoinkSystem changes * Change access on BwoinkSystem._messageQueues * Updates the Regex to support other Discord Clients (beta, alpha) * Merge Fixes * BwoinkSystem: explicitly match "canary."/"ptb." --------- Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com> Co-authored-by: Whatstone <whatston3@gmail.com>
…to discord-reply-system
…to discord-reply-system
…l/Delta-v into discord-reply-system
Proof of everything working added. |
Errors are unrelated, too. |
Looks awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theres more but overall theres a stupid amount of changes that it makes any upstream changes to this system a nightmare to manage, should be done upstream
Incapable of doing upstream, majority of this is AGPL from frontier. |
…to discord-reply-system
…l/Delta-v into discord-reply-system
@deltanedas @MilonPL i fixed :D |
…to discord-reply-system
…l/Delta-v into discord-reply-system
About the PR
This ports new-frontiers-14/frontier-station-14#2283 which allows admins to respond to AHelps while on discord.
Why / Balance
Not needing to be in-game to handle ahelps is a benefit for all admins.
Technical details
This PR requires:
This PR changes the way the BwoinkSystem works to allow for custom URLs instead of just an id and a token for webhooks, as well as adding an admin API HTTP POST method under
/admin/actions/send_bwoink
.Media
Requirements
Breaking changes
None
Changelog
🆑
ADMIN: